2.0 appshell

[sitedyno]

Load AppShell class.

This was discussed here and marked as resolved http://cakephp.lighthouseapp.com/projects/42648/tickets/1114-rfc-add-support-for-an-appshell-class but somehow the actual loading of the class got lost/left out.

[sitedyno]

There is something else I was wondering about. Shell::hasMethod() does a check to see if the method being called was declared by the current class or not. I assume this is to prevent public methods of Shell being used/abused out of context. The way the check is currently you cannot call public methods of AppShell either. I'm not sure if its a bug or feature ;) Any thoughts? It could easily be refactored to disallow things in Shell, but allow things from AppShell.

[renan]

Well, also the shells still don't extends the AppShell.
I believe that should be done as well, not sure though.

[markstory]

Looks like the loading of AppShell got lost in the conversion to App::uses() over App::import(), thanks for finding and fixing that.

My thoughts were that it seemed unlikely that you'd want a callable shell method on all shells in an application. I guess its theoretically possible you would. In that case you'd have to make sure the method wasn't declared on Shell. In any case I originally wrote it with the idea that someone wouldn't need the same callable method on every shell.

[renan]

Maybe not create a callable method on every shell, but changing the way the output is displayed or the input gathered.

[sitedyno]

Ya I don't see it as a big deal. Now that there is an AppShell, it's easy enough to overload hasMethod to get the behavior you want.

I don't think core shells need to extend AppShell. Could cause confusion and erroneous bug reports?

[markstory]

Yeah, they don't currently, and I plan on keeping them that way. Letting AppShell screw with bake is not the idea behind AppShell. :)