Missing templates should raise exceptions. #8555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing templates are a signal that a developer has made a mistake. We should help them find this error and an exception is the simplest way to signal an error to the developer. Refs #8554
| } | ||
| list($template, $placeholders) = $this->_compiled[$name]; | ||
| if ($template === null) { | ||
| return null; | ||
| } |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missing templates are a signal that a developer has made a mistake. We should help them find this error and an exception is the simplest way to signal an error to the developer.
Targeting this to
3.nextas it is a new error that I don't feel is appropriate at the bug-fix release level.Refs #8554