Update bootstrapping and configuration in 3.0 #860

markstory · 2012-09-20T01:48:01Z

Following the discussion on cakephp-core I've implemented most of the changes discussed but I'll reiterate some of the most important changes again.

Cache, Log, and Email now all use Configure for configuration data. The various config() methods now emit errors, and the EmailConfig class has been removed.
I have not updated ConnectionManager, but there is a connections.php with a possible approach. I figure ConnectionManager will be updated as the model layer is re-worked.
Support for PHP's include_path has been temporarily removed, but will come back when I start work on integrating composer.
The bootstrapping of a CakePHP application has in my opinion been greatly simplified and most voodoo has been removed. Declaration of all path related constants has been moved to App/Config as it simplifies overriding those constants.
Console bootstrapping is now the same as web request bootstrapping which is a nice bonus.

Changes to Log and Cache

Both Cache and Log now feature an engine() method. This method can be used to directly inject dependencies and fetch instances. It also allows Cache to lazily load all engines, which could help performance. Similarly, Log lazy loads loggers upon the first call to write().

Log has had all the backwards compatibility feature removed as they were deprecated.

Exceptions removed

A number of exceptions with very few uses have been removed. There was no real benefit from having additional marker exception classes.

Edit Finished the description, I accidentally submitted too soon.

Remove core.php it is no longer required.

Add default config files for email and datasources. Both config() methods are still not implemented.

Squash and revert a number of changes as they were just a bad idea.

Complete transition to using Configure for configuration.

* Update App/Config/cache.php to use Configure. * Remove Cache::isInitialized() as it is no longer required. * Add Cache::engine() this method allows lazy construction of cache engines. It also encapsulates checks for Cache.disable. * Update methods to use new methods. * Add several tests for set() as it had fairly sparse coverage and some common cases werw missing. * Missing cache configurations now trigger warnings about their absencse instead of silently returning false. While this may be too noisy in some situations, having silent failures makes debugging difficult as you are entirely unaware that no work isn't being done.

This will help people upgrade eaiser than just removing the method.

This can be helpful when doing testing, or if you have a CacheEngine that requires setup that is not feasible with the standard process.

Logging will soon be configured through Configure like other configurable parts of CakePHP.

Remove many the legacy features like: * Autoconfiguration of a file logger. You should remember to configure a logger if you want logging. * Ability to add/modify logging levels. There is really no reason for this functionality to exist. It was primarily a BC work around for people logging random messages and wanting them to show up in different log files. Logging scopes accomplish this in a far more extensible manner. * Removed the ability to log to undefined log levels. write() now returns false when you've logged to nothing. * When using defined levels/scopes both the scope & level of a message must intersect with the loggers scope/message or the message will be ignored. This makes logging more strict, but more predicatable.

Both these exception classes have very few callers and really don't offer the end user any additional information beyond a type.

* With only one thrower this exception was not worth its weight. Replace with the base CakePHP exception. * Update + fix tests for Cake\Model\Datasource\Session.

jrbasso · 2012-09-20T02:15:20Z

Awesome! 👍

zoghal · 2012-09-20T02:24:05Z

👍

renan · 2012-09-20T07:16:43Z

App/Config/app.php

+ */
+	Configure::write('Acl', [
+		'database' => 'default',
+		'classname', 'DbAcl',


Shouldn't it be 'className' => 'DbAcl' ?

bar · 2012-09-20T19:14:15Z

👍 too

lorenzo · 2012-09-20T22:24:38Z

App/Config/error.php

+/**
+ * Once configured, set the error/exception handlers to PHP's default handlers.
+ */
+	Configure::setErrorHandlers();


Can we move this function into the App class?

I don't see why not.

lorenzo · 2012-09-20T22:54:49Z

Nice work mark! One thing I was thinking is, can we still keep the dot notation for plugins? I find it boring having to specify the full class name for a class I want true in an engine. It is obviously cool and powerful being able to do so, but I don't expect everyone to remember exactly what the path is for each class

jrbasso · 2012-09-20T23:00:38Z

@lorenzo Yes. All classes that load others classes support dot notation or "partial" name. Having the full class name is just a faster way.

lorenzo · 2012-09-20T23:01:49Z

Oh, cool :)

Its no longer used and often a lie when path bootstrapping is used.

It works again.

markstory · 2012-09-21T02:31:06Z

I think I've addressed most of the comments. If there isn't anything else, I'll merge this in and start working on the next bit. Which will probably be restoring AllTests with incomplete test markers, as right now the test suite isn't overly usable.

Update bootstrapping and configuration in 3.0

markstory added 30 commits September 17, 2012 21:46

Start new bootstrapping prototype.

ef7cc5a

Consolidate more configuration data.

b4d655a

Update session configuration to not depend on Configure.

701cf08

Making App/Console/cake work again.

4bbc3c8

Update core cake command for new bootstrapping.

89eeb63

Move more configuration around.

262a141

Remove core.php it is no longer required.

Add file headers.

f17097c

Add default configuration files.

94e5811

Add default config files for email and datasources. Both config() methods are still not implemented.

Fix failing test.

4e9e1d8

Fix hardcoded view name and default values.

39443e3

Change the behavior of Email::config()

da4b48b

Squash and revert a number of changes as they were just a bad idea.

Finish reverting useConfig() changes.

61fb794

Complete transition to using Configure for configuration.

Update default datasources file.

c4c322e

Make Cache::config() emit errors.

9cc9b1b

This will help people upgrade eaiser than just removing the method.

Fix errors caused by missing parameter.

10e6dc2

Update FileEngine & its tests.

c9a4db3

Using Configure::write() is not optional.

fbf401f

Update ApcEngine & tests for Cache changes.

4f325a7

Add ability to directly inject an engine instance.

83b4e25

This can be helpful when doing testing, or if you have a CacheEngine that requires setup that is not feasible with the standard process.

Fix memcache tests.

92693ab

Update redis tests.

2ed9ff9

Update xcache tests

b4df110

Update wincache tests.

3a11f97

Update app/config/logging.php

74e7cc7

Logging will soon be configured through Configure like other configurable parts of CakePHP.

Update error message.

9d60a27

Make errors more informative.

c023efa

Remove LogException and CacheException

669ab20

Both these exception classes have very few callers and really don't offer the end user any additional information beyond a type.

Update console loggers.

44d1684

markstory added 6 commits September 17, 2012 21:52

Make error handling use Configure again.

5d2cef2

Update docs for Log\Log.

69778a0

Remove Cake\Error\SessionException

9f6dbc4

* With only one thrower this exception was not worth its weight. Replace with the base CakePHP exception. * Update + fix tests for Cake\Model\Datasource\Session.

Fix error made when rebasing branch.

5d7f6b3

Make -app parameter work again.

60bac77

Rename Config/email.default.php

1d74cee

renan reviewed Sep 20, 2012
View reviewed changes

lorenzo reviewed Sep 20, 2012
View reviewed changes

markstory added 5 commits September 20, 2012 20:23

Update configuration examples.

74b77a4

Remove APPLIBS

b5af663

Its no longer used and often a lie when path bootstrapping is used.

Update array notation.

bddea2b

Fix webroot/test.php

b03bee5

It works again.

Fix typo.

73954ba

lorenzo added a commit that referenced this pull request Sep 21, 2012

Merge pull request #860 from markstory/3.0-bootstrap

37047c6

Update bootstrapping and configuration in 3.0

lorenzo merged commit 37047c6 into cakephp:3.0 Sep 21, 2012

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update bootstrapping and configuration in 3.0 #860

Update bootstrapping and configuration in 3.0 #860

markstory commented Sep 20, 2012

jrbasso commented Sep 20, 2012

zoghal commented Sep 20, 2012

renan Sep 20, 2012

bar commented Sep 20, 2012

lorenzo Sep 20, 2012

markstory Sep 21, 2012

lorenzo commented Sep 20, 2012

jrbasso commented Sep 20, 2012

lorenzo commented Sep 20, 2012

markstory commented Sep 21, 2012

Update bootstrapping and configuration in 3.0 #860

Update bootstrapping and configuration in 3.0 #860

Conversation

markstory commented Sep 20, 2012

Changes to Log and Cache

Exceptions removed

jrbasso commented Sep 20, 2012

zoghal commented Sep 20, 2012

renan Sep 20, 2012

Choose a reason for hiding this comment

bar commented Sep 20, 2012

lorenzo Sep 20, 2012

Choose a reason for hiding this comment

markstory Sep 21, 2012

Choose a reason for hiding this comment

lorenzo commented Sep 20, 2012

jrbasso commented Sep 20, 2012

lorenzo commented Sep 20, 2012

markstory commented Sep 21, 2012