New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a validation method to validate the count of a value #8716
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f055942
Adding a validation method to validate the count of a value
dae46da
Adding an assert for Validation::count()
e61f21d
phpcs fixes and another assert for Validation::count()
92e6f56
Changing the count check in Validation::count()
7bec27a
Adding more asserts for Validation::count()
6e907dc
Renaming the count method and removing types it supports.
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -215,6 +215,26 @@ public static function cc($check, $type = 'fast', $deep = false, $regex = null) | |
return false; | ||
} | ||
|
||
/** | ||
* Used to check the count of a given value of type string, int, or array. | ||
* | ||
* If a string value is passed the string length is used as count. | ||
* | ||
* @param array|int|string $check1 The value to check the count on. | ||
* @param string $operator Can be either a word or operand | ||
* is greater >, is less <, greater or equal >= | ||
* less or equal <=, is less <, equal to ==, not equal != | ||
* @param int $expectedCount The expected count value. | ||
* @return bool Success | ||
*/ | ||
public static function numElements($check1, $operator, $expectedCount) | ||
{ | ||
if (!is_array($check1) || $check1 instanceof \Countable) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
return false; | ||
} | ||
return self::comparison(count($check1), $operator, $expectedCount); | ||
} | ||
|
||
/** | ||
* Used to compare 2 numeric values. | ||
* | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping the var name
$check
would be nice for consistency with other methods in class.