Update .travis.yml #9151
Closed
Update .travis.yml #9151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 89.57% (diff: 100%)@@ master #9151 diff @@
==========================================
Files 368 368
Lines 27001 28610 +1609
Methods 3233 3274 +41
Messages 0 0
Branches 0 0
==========================================
- Hits 25637 25627 -10
- Misses 1364 2983 +1619
Partials 0 0
|
| - if [[ $DEFAULT = 1 && $TRAVIS_PHP_VERSION = 7.0 && $DB != 'mysql' ]]; then export CODECOVERAGE=1; vendor/bin/phpunit tests/TestCase/DatabaseSuite.php --coverage-clover=clover.xml; fi | ||
|
|
||
| - if [[ $DEFAULT = 1 && $TRAVIS_PHP_VERSION != 7.0 && $DB = 'mysql' ]]; then vendor/bin/phpunit; fi | ||
| - if [[ $DEFAULT = 1 && $TRAVIS_PHP_VERSION != 7.0 && $DB != 'mysql' ]]; then vendor/bin/phpunit tests/TestCase/DatabaseSuite.php; fi |
There was a problem hiding this comment.
Could't you use the --testsuite option here ?
|
Hmm codecov is not impressed. Let me see if I can get coverage to previous level else I'll close the PR. |
Only run DatabaseSuite for non-mysql to speed up tests.
|
Some of the tests must not be grouped correctly. |
|
@thinkingmedia Maybe, but I am not inclined to review the test cases and find out :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only run DatabaseSuite for non-mysql to speed up tests.