Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

For ticket #3315 #925

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

LiquidityC commented Oct 28, 2012

My first ever contribution. Please respond to malformed commitmsgs or any other stuff that I missed when reading contribution faqs.

Milestone was future and the diff is pretty short. I'm sure I missed alot... I'm just getting started.

Member

AD7six commented Oct 28, 2012

The parse error kind of gets in the way. Fixing that there is an E_STRICT error

me: What ticket or problem does this method address?

Edit - I read title :)

Owner

markstory commented Oct 29, 2012

Won't this mean that the content between the start() / end() blocks would just be output as normal content? I don't think that is correct either. Instead what you want is a capturing block that is discarded when end() is called. Currently this won't solve the issue, as the block will be output inline.

Contributor

LiquidityC commented Oct 29, 2012

Ummm. Yeah you're right. I'm not thinking straight at all. Thought it would
be a quick fix. Gotta stop coding to early into the mornings. I'll look
over it.
On 29 Oct 2012 01:43, "Mark Story" notifications@github.com wrote:

Won't this mean that the content between the start() / end() blocks would
just be output as normal content? I don't think that is correct either.
Instead what you want is a capturing block that is discarded when end() is
called. Currently this won't solve the issue, as the block will be output
inline.


Reply to this email directly or view it on GitHubhttps://github.com/cakephp/cakephp/pull/925#issuecomment-9853620.

Contributor

LiquidityC commented Oct 29, 2012

I think I did it right now, tested properly and all. Atleast the useless pullrequest got me started. Hope this one is good enough. Please get back to me with any syntax, comment or logic improvements that you need/expect/demand :P

Contributor

LiquidityC commented Oct 29, 2012

I need to a move this to a new branch in my fork so it won't get in the way of my other work. Also allowing me to fiddle around a bit. New pullrequest will be posted shortly. Sorry about all the fiddling around.

@LiquidityC LiquidityC closed this Oct 29, 2012

Member

ADmad commented Oct 30, 2012

@LiquidityC Since this is a new feature make sure the new pull request is against the 2.3 branch not master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment