Quote identifiers for numeric fields on insert queries. #9395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quote numeric column names as we would quote string column names. Refs #9391
| $query->insert([123]) | ||
| ->into('articles') | ||
| ->values([ | ||
| 123 => 'mark', |
There was a problem hiding this comment.
Even if a column name is numeric shouldn't one use string '123' for it? It's silly to use integer to represent a column name IMO.
|
I fixed all the whitespace related PHPCS errors in this pull request too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quote numeric column names as we would quote string column names.
Refs #9391