Add lib ICU min. requirement #9700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 94.94% (diff: 100%)@@ 3.next #9700 diff @@
==========================================
Files 416 416
Lines 28934 28934
Methods 3502 3502
Messages 0 0
Branches 0 0
==========================================
Hits 27470 27470
Misses 1464 1464
Partials 0 0
|
|
Can you please add the same to |
markstory
added a commit
that referenced
this pull request
Nov 3, 2016
|
@ADmad done postmerge. |
|
Thank you both 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9697.
Maybe we should also update the docs.