Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .mailmap #9710

Merged
merged 5 commits into from
Nov 7, 2016
Merged

Add .mailmap #9710

merged 5 commits into from
Nov 7, 2016

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented Nov 5, 2016

Other team members please add your name/email combinations to the file :)

@ADmad ADmad added this to the 3.3.8 milestone Nov 5, 2016
@markstory
Copy link
Member

Ping @dereuromark As you have a pile of aliases.

@@ -4,3 +4,6 @@ José Lorenzo Rodríguez <jose.zap@gmail.com>
José Lorenzo Rodríguez <jose.zap@gmail.com> <lorenzo@users.noreply.github.com>
José Lorenzo Rodríguez <jose.zap@gmail.com> José Lorenzo Rodríguez Urdaneta <lorenzo@Venus-2.local>
ADmad <admad.coder@gmail.com> <ADmad@users.noreply.github.com>
thinkingmedia <mathew@thinkingmedia.ca>
Thinking Media <thinkingmedia@users.noreply.github.com>
Mathew Foscarini <mathew@thinkingmedia.ca>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the goal of mailmap is to make the names consistent across all your mail aliases.

@ADmad
Copy link
Member Author

ADmad commented Nov 5, 2016

@thinkingmedia Still incorrect. The aim is to get only one name-email pair for yourself in output of git shortlog -sne. Please check locally before pushing more commits :) You can see multiple references here.

@codecov-io
Copy link

codecov-io commented Nov 5, 2016

Current coverage is 94.94% (diff: 100%)

Merging #9710 into master will increase coverage by <.01%

@@             master      #9710   diff @@
==========================================
  Files           414        414          
  Lines         28486      28486          
  Methods        3404       3404          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          27044      27046     +2   
+ Misses         1442       1440     -2   
  Partials          0          0          

Powered by Codecov. Last update 51e461f...171242d

@markstory markstory merged commit 6c2e864 into master Nov 7, 2016
@markstory markstory deleted the mailmap branch November 7, 2016 02:06
@dakota dakota restored the mailmap branch November 7, 2016 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants