Fixed the handling of HttpSocket's response body #52
Conversation
|
Can you please provide a test to prove there was a problem initially? and to avoid us breaking something in the future :) |
|
merged the recent PR from 2.3 and added a test for the request method. in 2.3 the entire Httpsocket object is being treated as the http response and it is assumed to be XML response. This makes it always return an empty array. The test passes in the PR and fails in 2.3. All future fixes will include a test ;-) |
| * @return void | ||
| * @access public | ||
| */ | ||
| function testRequestReturnsExpectedData() { |
There was a problem hiding this comment.
Should be public function. And we dont use "@access" anymore.
There was a problem hiding this comment.
honestly i just choose to do so because its the style of the entire class. i have in my notes to do a proper clean. this class was ported from some 1.x branch. I figured fixing the ugly php4 coding would be a seperate PR altogether.
There was a problem hiding this comment.
Fair enough. I just saw the diff :)
HttpSocket returns an object with body holding the response. Not the response itself. Maybe at some point it returned what we now expect HttpSocket->body to be. Also, as per http://book.cakephp.org/2.0/en/core-utility-libraries/xml.html#importing-data-to-xml-class and http://book.cakephp.org/2.0/en/core-utility-libraries/xml.html#transforming-a-xml-string-in-array I made use of how we now ( as in 2.x ) convert XML to array