-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roadmap v5.0 #88
Comments
Targeting CakePHP 4.0 (or 3.7) only? |
Probably CakePHP 4.0, but if 3.7 isn't to much of an hassle that would be awesome. The thing is I would prefer to support the same minimum PHP version as CakePHP 4.0 with this 5.0 release. |
@ADmad && @markstory Any things on cake's wishlist for 5.0 (targeting cakephp 4.0)? |
I would love to help find a way to not need |
@markstory looking into how to sanely do that 👍 |
Just skimming through twig docs I couldn't find a way to tell twig to disable escape for specific vars used in So avoiding the need for using |
There might be something deeper in the API to do this, not entirely sure. Like the idea, not 100% sold on the syntax but I'll get an experiment on this weekend to implement it and see where we can take it from there 👍 . |
@ADmad TwigView could use reflection to generate twig functions for all defined helper methods. Twig functions can indicate that they are escapers. This would add a bit of overhead but could be something that is 'compiled' or cached. |
@markstory Yeah using reflection in On a related note could be shorten the tag for |
Having helpers as regular variables also has the drawback that if someone doesn't follow conventions and for e.g. sets a view var named |
Sure, could probably do both 😜 |
@ADmad just been digging around and found this: https://twig.symfony.com/doc/2.x/advanced.html#automatic-escaping |
@WyriHaximus Yes, that would be really useful on Helper proxy functions. |
I was looking into updating I tried to work on TwigView first ignoring the Bake dependency but the 1st blocker is the |
@ADmad lets fix that! If Also we could make bake an optional dev dependency that we load on the CI when running tests but isn't a dev requirement if that untangles things. |
It's final. |
Ok cool! How far from releasing are you? |
As always "When it's ready" :) |
Cool, the underlying question was: How fast does this needs to be done. But I'll get onto some stuff after my Honeymoon and dedicate some days to straightening things out and get them CakePHP 4 ready 👍 . |
No worries. Congrats on your wedding and enjoy your honeymoon 🙂 |
Thank you, enjoying it a lot 😎 ! |
I've been taking a look at this repo lately because we are considering to implement this in our project, however, I feel like it's "odd" to have to rename all the |
@FinlayDaG33k "regular" .ctp files contain PHP code :). Why would you unnecessarily confuse any new dev joining your project by using .ctp extension instead of the default .twig for Twig files? |
It's not only that, |
Well, to me, it feels more confusing that everything is
This wasn't in the documentation, I'll add that in a bit :) |
Cool 👍 ! |
the files should be whatever they are. so if those are twig templates, then the file extension should be .twig. As for the new Cake4 release, any plans on releasing a beta already or sth?
this is blocking other plugins to become stable.
|
PS: Once you got a beta tag out, like the other plugins now, you can add the strawberry: FriendsOfCake/awesome-cakephp#334 :) |
@dereuromark Hopefully this weekend. Will let you know once the tag is out |
|
Todo:
7.1
4.x
branchResearch:
|raw
everywhere isn't required (via @markstory)The text was updated successfully, but these errors were encountered: