Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark plugins which have CakePHP 4 compatible releases #334

Merged
merged 6 commits into from
Dec 28, 2019
Merged

Conversation

ADmad
Copy link
Member

@ADmad ADmad commented Dec 27, 2019

No description provided.

- [Localized plugin](https://github.com/cakephp/localized) - Localized validation and ready-to-use translation PO files.
- [ShadowTranslate plugin](https://github.com/AD7six/cakephp-shadow-translate) - A plugin with shadow table based replacement for core's Translate behavior.
- :strawberry: [ShadowTranslate plugin](https://github.com/AD7six/cakephp-shadow-translate) - A plugin with shadow table based replacement for core's Translate behavior.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plugin itself has no 4.x support.

Add information about how to upgrade to core version in the plugin repository or link to the book.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup I am going to update the plugin's readme to point to relevent manual page for 4.x.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does that mean it is actually somewhat deprecated as plugin now?

@dereuromark
Copy link
Member

Releases = at least beta tag? no dev-master branch only, right?

@ADmad
Copy link
Member Author

ADmad commented Dec 27, 2019

@dereuromark Yup

@dereuromark
Copy link
Member

@josbeir
Copy link
Contributor

josbeir commented Dec 28, 2019

You can add (made a release for 4.x)

@ADmad ADmad merged commit 1cbd173 into master Dec 28, 2019
@ADmad ADmad deleted the ADmad-patch-1 branch December 28, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants