Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Twig Extension, remove type array, add .twig ext, add none filter #26

Merged
merged 6 commits into from
Jul 15, 2016
Merged

Twig Extension, remove type array, add .twig ext, add none filter #26

merged 6 commits into from
Jul 15, 2016

Commits on Jul 13, 2016

  1. Update Cell.php

    @vonboth
    vonboth committed Jul 13, 2016
    Configuration menu
    Copy the full SHA
    1862ea9 View commit details
    Browse the repository at this point in the history

  2. Adding .twig extension to the extensions array 

    PHPStorm interprets .tpl as Smarty templates and doesn't support the TwigPlugin.
The to use templates with .twig extension it needs to be part of the array
    @vonboth
    vonboth committed Jul 13, 2016
    Configuration menu
    Copy the full SHA
    c270b74 View commit details
    Browse the repository at this point in the history

  3. Update Cell.php

    @vonboth
    vonboth committed Jul 13, 2016
    Configuration menu
    Copy the full SHA
    9ce41ac View commit details
    Browse the repository at this point in the history

  4. Removing type from variable $variable 

    Php throws a warning 

see:  https://scrutinizer-ci.com/g/WyriHaximus/TwigView/issues/master/files/src/Lib/Twig/TokenParser/Cell.php?orderField=path&order=asc&honorSelectedPaths=0
    @vonboth
    vonboth committed Jul 13, 2016
    Configuration menu
    Copy the full SHA
    08c6bd6 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2016

  1. Creating 'None'-filter 

    The filter returns and stops further filtering propagation.
Use the filter in CakePHP/Twig in combination with Helper functions returning Objects instead of strings.
E.g. $this->Html->addCrumb('Some Crumb') becomes {{ Html.addCrumb('Some Crumb') | none }}
    @vonboth
    vonboth committed Jul 14, 2016
    Configuration menu
    Copy the full SHA
    251f399 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2016

  1. Fixing code style rules

    @vonboth
    vonboth committed Jul 15, 2016
    Configuration menu
    Copy the full SHA
    2a3fb06 View commit details
    Browse the repository at this point in the history