Return '' on echo $this; for TwigView #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fix {{ _view.assign('foo', 'bar') }} and similar uses (that are a bit wrong and should be {% _view.assign('foo', 'bar') %};
Latter will hopefully be fixed in 5.x - however templates then will need to be updated at some point before this hack can be removed again.
|
Alternative to cakephp/cakephp#11217 (however if 11217 is merged, we should still do this here as 11217 should probably be removed at some point from the core if it gets added) Closes #60 |
dereuromark
approved these changes
Sep 20, 2017
Closed
|
LGTM, but we should as suggested do #62 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix
{{ _view.assign('foo', 'bar') }}and similar uses (that are a bit wrong and should be{% _view.assign('foo', 'bar') %};Latter will hopefully be possible/fixed in 5.x through some new twig tags. However templates then will need to be updated at some point before this hack can be removed again.