-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the tests so they pass again following the release of phinx 0.4.6 #123
Conversation
This phinx release introduced changes in the naming scheme the migration files / the migration classes should follow, breaking the tests. This commit also removes the ``update()`` call after the ``dropForeignKey()`` calls : it was not necessary.
19f31d1
to
d0d8d89
Compare
fbf08e5
to
155d42c
Compare
I pushed a new commit that contains a few things. First of all, since nothing has moved on phinx's side, I decided to implement a temporary fix to fix the cause of the tests failures with SQLite. I'll remove it once (and if) the PR on phinx repo is merged. While doing that, I noticed a defect : the Migrations class was not using the CakeAdapter but the Adapter from phinx which prevented the bugfix to fix anything. So I fixed this along the way. Tests should be passing again now. |
155d42c
to
8e0cc3e
Compare
…ry fix to the SQLite adapter to prevent it from dropping tables when using dropForeignKey Also change implementation on code tested using the Migrations class (which used to use the Phinx adapter and not the Cake one, leading to unexpected results when the Cake one is used)
8e0cc3e
to
330c914
Compare
PR on phinx has been merged. We just need a release now for the tests to pass. I updated the code to remove the temp fix I added. |
I pushed a commit where I change the dependency for phinx to What do you think ? |
I think that plan makes sense @HavokInspiration |
Update the tests so they pass again following the release of phinx 0.4.6
This should not be merged right now
This phinx release and this PR shed some light on some migrations tests that were not done. Now that they are all running, I spotted a bug in phinx implementation of the mechanism to drop foreign key constraints with SQLite. I submitted a PR on phinx repo : cakephp/phinx#641
The test suite will be failing for SQLite until the change I will propose will be merged and a new phinx release is
This phinx release introduced changes in the naming scheme the migration files / the migration classes should follow, breaking the tests.
This commit also removes the
update()
call after thedropForeignKey()
calls : it was not necessary.