Add the ability to specify the field length to the bake command #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job! 👏 |
lorenzo
added a commit
that referenced
this pull request
Oct 14, 2015
Add the ability to specify the field length to the bake command
|
|
||
| The length parameter for the ``fieldType`` is optionnal and should always be |
There was a problem hiding this comment.
Extra n on optional here ;)
There was a problem hiding this comment.
Fixed with a432326
Thanks @josegonzalez
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to specify the field length when baking a new migration file by allowing the
fieldTypesyntax to accept a number written within brackets :bin/cake bake migrations create_users username:string[128]I went with brackets because parenthesis cause the shell call to fail.
I did not add any test to control the length specified other than the one that were already done because phinx does it with the adapters and default sizes based on the field type.
Refs to #128