Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with field name starting with a delimiter #148

Merged
merged 1 commit into from
Nov 9, 2015
Merged

Conversation

antograssiot
Copy link
Contributor

ref #147

@antograssiot antograssiot added this to the 1.4.1 milestone Nov 9, 2015
@antograssiot
Copy link
Contributor Author

the failling tests are not related...

lorenzo added a commit that referenced this pull request Nov 9, 2015
fix issue with field name starting with a delimiter
@lorenzo lorenzo merged commit 1a17c6e into master Nov 9, 2015
@lorenzo lorenzo deleted the issue-147 branch November 9, 2015 22:43
@lorenzo
Copy link
Member

lorenzo commented Nov 9, 2015

I wonder where test broke

@HavokInspiration
Copy link
Member

@lorenzo I suspect from here cakephp/phinx#671 but I can't run tests right now to confirm it.

@antograssiot
Copy link
Contributor Author

@HavokInspiration that was my first guess but it hasn't been merged in master yet...

@HavokInspiration
Copy link
Member

@antograssiot The branch 0.4.x-dev is considered master with phinx. So this is probably the root cause of the issue.

@antograssiot
Copy link
Contributor Author

@HavokInspiration Ah ok, I was pretty sure that you would need to require dev-0.4.x-dev as listed on packagist to get the latest 0.4 but I might be totaly wrong.

@HavokInspiration
Copy link
Member

Using dev-master fetch from 0.4.x-dev (if you go on phinx repo and check the default branch, you'll notice that it is not master) (this is at least what I observed when I changed the dependency version to dev-master when two fixes I added were merged in 0.4.x-dev but not released)

@HavokInspiration
Copy link
Member

I investigated the tests failure but I was not able to reproduce them (either on my local setup at home and on a VM I use at work).
The errors were suppressed with a recent PR though.

@HavokInspiration HavokInspiration modified the milestones: 1.5, 1.4.1 Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants