Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to create snapshot for all tables from plugin #153

Merged
merged 1 commit into from
Nov 26, 2015

Conversation

GrandFelix
Copy link
Contributor

Fix to create snapshot for all tables from plugin when using --plugin and --require-table options. Now only creates snapshot for only one table from plugin

…require-table options. Now only create snapshot for only one table
@HavokInspiration
Copy link
Member

What is the issue this is trying to fix ? I don't understand.
Can you provide a way to reproduce the issue you are submitting a fix for ?

@HavokInspiration HavokInspiration added this to the 1.4.1 milestone Nov 22, 2015
@GrandFelix
Copy link
Contributor Author

When I tried to create migration_snapshot for plugin like:
cake bake migration_snapshot Initial --plugin Countries --require-table
I just get result in migration file for only one table from that plugin, but plugin have 4 tables. With this change I get all four tables in migration file...

@HavokInspiration
Copy link
Member

Thanks for the extra context, I can reproduce the issue.

@HavokInspiration
Copy link
Member

Looks good to me.
This is going to need some tests though.

@HavokInspiration
Copy link
Member

Merging.
I'll submit a PR with a test shortly.

HavokInspiration added a commit that referenced this pull request Nov 26, 2015
Fix to create snapshot for all tables from plugin
@HavokInspiration HavokInspiration merged commit 7da0df7 into cakephp:master Nov 26, 2015
HavokInspiration added a commit to HavokInspiration/migrations that referenced this pull request Nov 26, 2015
HavokInspiration added a commit to HavokInspiration/migrations that referenced this pull request Nov 26, 2015
HavokInspiration added a commit to HavokInspiration/migrations that referenced this pull request Nov 26, 2015
lorenzo added a commit that referenced this pull request Nov 27, 2015
@HavokInspiration HavokInspiration modified the milestones: 1.5, 1.4.1 Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants