Refactor snapshot baking tests #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some tests were split because of a feature added in a release of CakePHP 3.0.X. Since we require 3.1.0 as a minimum requirement now, those tests can be done in one test.
|
Nice! |
lorenzo
added a commit
that referenced
this pull request
Nov 22, 2015
Refactor snapshot baking tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating the MySQL build failures, I realized that some "optimization" could be done regarding snapshot baking tests.
Some tests were split because of a feature added in a release of CakePHP 3.0.X. (composite Foreign Key).
Since we now require 3.1.0 as a minimum requirement now for the plugin, those tests can be done in one test.
Note that this solves the MySQL build issue as well.
I suspect there is something smelly with the way
FixturesManager::loadSingle()method deals with constraints (used byTestCase::loadFixtures()that was used before this PR) when not using auto fixtures in tests. However, I could not reproduce the build failure Travis was reporting.I'll try on a VM I have lying around at work on which I generally can reproduce Travis build failure. If I can reproduce the issue, I'll investigate.