Table names with db prefix not included in migration snapshots #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, ensure it matches with current connection database name.
makallio85
changed the title
| @@ -246,7 +246,15 @@ public function fetchTableName($className, $pluginName = null) | |||
| $tables[] = $table->associations()->get($key)->_junctionTableName(); | |||
| } | |||
| } | |||
| $tables[] = $table->table(); | |||
| $t = $table->table(); | |||
| $splitted = array_reverse(explode('.', $t)); | |||
There was a problem hiding this comment.
Are you assuming that the plugin name is the prefix?
There was a problem hiding this comment.
I think @makallio85 wants to cover the case where you define your table name as schema.table.
There was a problem hiding this comment.
@HavokInspiration You are correct.
|
I'm ok with the improvement but we need tests to make sure it works as expected for all db vendors (and avoid future regressions). Any thoughts on this @josegonzalez ? |
|
@HavokInspiration Yes please ;) |
|
Closing in favor of #195 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Table name can be prefixed with database name. If prefix is present, ensure it matches with current connection database name.