Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include the "unsigned" attribute in snapshot #198

Merged
merged 1 commit into from Feb 9, 2016
Merged

Conversation

HavokInspiration
Copy link
Member

This change will not have any effect on Postgres, which does not support signed integer.
Support for SQLite is limited to non-primary keys integers, as SQLite does not support integer unsigned primary keys.
MySQL support unsigned for both integer primary keys and simple integer.

This explains the differences between the comparisons files for each db vendors.

Refs #197

This change will not have any effect on Postgres, which does not support signed integer.
Support for SQLite is limited to non-primary keys integers, as SQLite does not support integer unsigned primary keys.
MySQL support unsigned for both integer primary keys and simple integer.
@lorenzo
Copy link
Member

lorenzo commented Feb 9, 2016

Great job!

lorenzo added a commit that referenced this pull request Feb 9, 2016
Include the "unsigned" attribute in snapshot
@lorenzo lorenzo merged commit 7ac1946 into master Feb 9, 2016
@lorenzo lorenzo deleted the signed-attribute branch February 9, 2016 21:41
@HavokInspiration
Copy link
Member Author

I'm glad to see that codecov report works.
I'll do the 1.5.6 release later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants