Dump command and require-table

[HavokInspiration]

The dump command should not set require-table to true when fetching the tables to add to the dump because it can lead to unexpected results as reported in #232 and #244.

It turned out the issue experienced by @ypnos-web and @dereuromark are because of this option.

@lorenzo As specified in #232, it should be known that tables from plugins will also be added to the dump when migrating or rolling back a set of migrations (basically, the system will now add every tables it finds in the dump), potentially creating a situations where tables from plugin will be added in diffs.
Maybe there could be an option in the migration diff command to exclude tables :

• by specifying a list of table names
• by specifying a plugin name. When used it will fetch all ORM table classes in the said plugin and exclude them from the diff.

We can keep the idea on the side right now and consider it if you have users reporting this issue. What do you think ?

[lorenzo]

I think this is a step in the right direction.

What happens if I set the require tables to true and also a plugin option? Would it save the dump in the plugin only for the tables in the plugin?

[HavokInspiration]

There is no require-table option on the dump command. But that can be added.

However, when a plugin option is found, whether or not there is a require-table option set and whatever its value, it will only fetch tables that have a Table class in order to really filter the table from the plugin. There is no better way to do it from my point of view.
That is valid for snapshots as well (this logic was first implemented for snapshots)