Add support for specifying a nullable field #203 #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for using the "?" as a suffix to the column data type to indicate that it is nullable.
Example:
bin/cake bake migration CreatePerson name:string description:string? age:integer?
name:string description:string? age:integer?
…n comparison for the generated integer column
| @@ -51,11 +51,14 @@ public function parseFields($arguments) | |||
| } | |||
| } | |||
|
|
|||
| $nullable = substr($type, -1) == '?'; | |||
Current coverage is 33.25%@@ master #249 diff @@
==========================================
Files 31 31
Lines 1748 1750 +2
Methods 212 212
Messages 0 0
Branches 0 0
==========================================
Hits 582 582
- Misses 1166 1168 +2
Partials 0 0
|
|
@dereuromark Thank you for your feedback. I have just made the changes that you have suggested, and I pushed them to the fork; the committed changes now appear in the pull request. |
| @@ -51,11 +51,14 @@ public function parseFields($arguments) | |||
| } | |||
| } | |||
|
|
|||
| $nullable = substr($type, -1) === '?'; | |||
| $type = $nullable ? substr($type, 0, strlen($type) - 1) : $type; | |||
There was a problem hiding this comment.
The substr($type, 0, strlen($type) - 1) part could be replaced with only substr($type, 0, -1)
|
Other than my comment, this looks good to me. |
This was referenced Jun 22, 2016
|
@HavokInspiration : I have made the change that you suggested and I look forward to your continued guidance in future. |
|
Great work! |
|
👏 |
|
Good job! |
|
@nitincoded Would you mind changing the docs to add this new feature? |
nitincoded
added a commit
to nitincoded/docs
that referenced
this pull request
Jun 23, 2016
This feature is being introduced in cakephp/migrations v1.6.3. Reference: Issue cakephp/migrations#203 / PR cakephp/migrations#249
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch provides the ability to specify that a column is nullable in a migration from the CakePHP bake command line by adding a question mark as a suffix to the column data type.
Example:
bin/cake bake migration CreatePerson name:string description:string? age:integer?The patch applies to the ColumnParser class in src/Util/ColumnParser.php file and the diff can be found at:
nitincoded@bd453ee
A test was also added to the PHP Unit test in the ColumnParserTest class.