Migration generation via cli #34

josegonzalez · 2014-12-07T17:32:28Z

This is my first pass at making migration baking a little easier to use.

Moved the existing bake behavior to a --snapshot option
Moved the template to migration.ctp to snapshot.ctp
Cleaned up the actual bake task a bit
Added a MigrationHelper class to handle data output for migration files

This PR handles the signed/unsigned bug, and adds support for more phinx-supported attributes.

TODO:

Update docs
Rails-style migration generation
Test bake output the same way that the core does
Add tests for the MigrationHelper class

lorenzo · 2014-12-07T21:41:52Z

src/Shell/Task/MigrationTask.php

+    protected function getMigrationName($name = null)
+    {
+        if (empty($name)) {
+            return $this->error('Choose a migration name to bake in underscore format');


Phenix uses a camel case format for migrations names in the command line, we should follow that decision

The name of the class is UpperCamelCase though.

lorenzo · 2014-12-07T21:43:33Z

I really like the direction this is going

markstory · 2014-12-08T01:13:58Z

src/Shell/Task/MigrationTask.php

@@ -121,7 +121,7 @@ public function bake($filename)

        $this->Template->set($data);

-        $out = $this->Template->generate('Migrations.config/migration');
+        $out = $this->Template->generate('Migrations.config/initial');


Migrations.config/snapshot instead?

Ah I thought I fixed this...

markstory · 2014-12-08T01:16:43Z

I too like the direction. Nice work @josegonzalez 👍

dereuromark · 2014-12-10T16:54:42Z

src/Shell/Task/MigrationTask.php

     * @return void
     */
-    public function main($name = null)
+    public function main()


Why did you remove that? I thought the passed param here in 3.x is a little bit nicer than running through $this->args via array_shift, effectively modifying $this->args in the process.

If you specify arguments in the ConsoleOptionParser, you cannot use arbitrary args (which are necessary for rails-style migration generation).

I see, but then $this->args[0] would still be better IMO to not modify the args.

Feel free to update the PR 💃

lorenzo · 2014-12-11T07:42:53Z

src/Util/ColumnParser.php

+        $validTypes = array_values($collection->filter(function ($_, $constant) {
+            $_;
+            return substr($constant, 0, strlen('PHINX_TYPE_')) === 'PHINX_TYPE_';
+        })->toArray());


toArray(false) Will do save you the call to array_values()

josegonzalez · 2015-01-29T17:02:10Z

I'm having a bit of troubling getting fixtures to run. I'm going to push my current code in the hopes that someone can figure out why fixtures aren't being inserted into the db...

jadb · 2015-01-29T17:23:08Z

@josegonzalez I'll try it some time today or tomorrow and share what I find.

josegonzalez · 2015-02-15T03:15:45Z

I ended up splitting out the snapshot generation and generation from the cli into two different tasks. I might still consolidate them to keep the interface the same, but I like how it came out :)

Also extend the SimpleBakeTask, reducing the amount of code needed to generate a given migration file.

The current version of phinx automatically includes a primaryKey field, which would break snapshot application

Due to how the CakePHP PostgresSchema class treats length on integer-like fields, we cannot depend upon the output to compare correctly when using postgres as a datasource. Refs cakephp/cakephp#5901

lorenzo · 2015-02-19T21:55:42Z

.travis.yml

    - php: hhvm-nightly
+    - env: DB=pgsql db_dsn='postgres://postgres@127.0.0.1/cakephp_test'


Oh, thats related to a bug in the schema generation in CakePHP. See this commit for more details.

lorenzo · 2015-02-19T22:03:28Z

This looks great! 👍

markstory · 2015-02-20T14:32:30Z

tests/TestCase/Util/ColumnParserTest.php

+                    'limit' => 11,
+                ],
+            ],
+        ], $this->columnParser->parseFields(['id:primary']));


Some troll is going to want : in their column names.

That troll can write his own migrations sans the cli-based generator.

markstory · 2015-02-20T14:35:31Z

Looks great 👍

Migration generation

lorenzo reviewed Dec 7, 2014
View reviewed changes

markstory added this to the 1.0.0 milestone Dec 8, 2014

markstory reviewed Dec 8, 2014
View reviewed changes

markstory mentioned this pull request Dec 8, 2014

Fix the unsigned issue #32

Closed

josegonzalez force-pushed the migration-generation branch from cd41be4 to 5239d34 Compare December 9, 2014 06:53

markstory mentioned this pull request Dec 10, 2014

'unsigned' is not a valid column option. #29

Closed

dereuromark reviewed Dec 10, 2014
View reviewed changes

josegonzalez force-pushed the migration-generation branch from 567f07b to a1cefbd Compare December 11, 2014 05:09

lorenzo reviewed Dec 11, 2014
View reviewed changes

josegonzalez force-pushed the migration-generation branch from a1cefbd to 808e034 Compare January 6, 2015 17:13

markstory mentioned this pull request Jan 17, 2015

unsigned not a vaild column #44

Closed

josegonzalez force-pushed the migration-generation branch from 962f9aa to 76f260a Compare January 29, 2015 08:54

jadb self-assigned this Jan 29, 2015

josegonzalez force-pushed the migration-generation branch from 3cffdd5 to 7afdf08 Compare February 8, 2015 23:00

josegonzalez force-pushed the migration-generation branch from 105f26d to 1b1e42b Compare February 15, 2015 05:51

josegonzalez added 19 commits February 15, 2015 01:03

add hack for pgsql

44ceef9

Pgsql reports string limit as null for some reason

d935d32

Fix PHPCS length violation

faaa177

Remove unneeded installer-name

1580f6d

Updated test bootstrap

aae1a56

Modify indentation strategy to follow PSR-2

998dbac

Added tests for migration generation

0f19f59

Also extend the SimpleBakeTask, reducing the amount of code needed to generate a given migration file.

Use the same autoload-dev as is used in bake plugin

224b321

More migration generation tests

164f10e

Remove unused integerLimit

87d912d

Swap usage of TemplateTask to BakeTemplateTask

7aca293

Remove single-column primary keys from snapshot

521c01d

The current version of phinx automatically includes a primaryKey field, which would break snapshot application

Fix PHPCS violations in tests

1aabbdd

Ignore comparison files in phpcs checks

1fa6f26

Sort arrays by key alphabetically

6d3346b

Fix travis tests for hhvm

7456763

Fix PHPCs issues

2e259f9

Allow postgres to fail

a57b25e

Due to how the CakePHP PostgresSchema class treats length on integer-like fields, we cannot depend upon the output to compare correctly when using postgres as a datasource. Refs cakephp/cakephp#5901

Fix phpcs issue

b334a85

josegonzalez force-pushed the migration-generation branch from 1b1e42b to b334a85 Compare February 15, 2015 06:04

lorenzo reviewed Feb 19, 2015
View reviewed changes

markstory reviewed Feb 20, 2015
View reviewed changes

markstory added a commit that referenced this pull request Feb 21, 2015

Merge pull request #34 from cakephp/migration-generation

b4f5a77

Migration generation

markstory merged commit b4f5a77 into master Feb 21, 2015

markstory deleted the migration-generation branch February 21, 2015 00:47

josegonzalez changed the title ~~Migration generation~~ Migration generation via cli Nov 14, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migration generation via cli #34

Migration generation via cli #34

josegonzalez commented Dec 7, 2014

lorenzo Dec 7, 2014

josegonzalez Dec 8, 2014

lorenzo commented Dec 7, 2014

markstory Dec 8, 2014

josegonzalez Dec 8, 2014

markstory commented Dec 8, 2014

dereuromark Dec 10, 2014

josegonzalez Dec 10, 2014

dereuromark Dec 10, 2014

josegonzalez Dec 10, 2014

lorenzo Dec 11, 2014

josegonzalez commented Jan 29, 2015

jadb commented Jan 29, 2015

josegonzalez commented Feb 15, 2015

lorenzo Feb 19, 2015

josegonzalez Feb 19, 2015

josegonzalez Feb 19, 2015

lorenzo commented Feb 19, 2015

markstory Feb 20, 2015

josegonzalez Feb 20, 2015

jadb Feb 20, 2015

markstory commented Feb 20, 2015

		- php: hhvm-nightly
		- env: DB=pgsql db_dsn='postgres://postgres@127.0.0.1/cakephp_test'

Migration generation via cli #34

Migration generation via cli #34

Conversation

josegonzalez commented Dec 7, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lorenzo commented Dec 7, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markstory commented Dec 8, 2014

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

josegonzalez commented Jan 29, 2015

jadb commented Jan 29, 2015

josegonzalez commented Feb 15, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lorenzo commented Feb 19, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

markstory commented Feb 20, 2015