Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CakePHP 4.x Version of Plugin. #391

Merged
merged 18 commits into from
Jul 21, 2019
Merged

CakePHP 4.x Version of Plugin. #391

merged 18 commits into from
Jul 21, 2019

Conversation

skie
Copy link
Member

@skie skie commented May 30, 2019

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

The best way to propose a feature is to open an issue first and discuss your ideas there before implementing them.

Always follow the contribution guidelines when submitting a pull request. In particular, make sure existing tests still pass, and add tests for all new behavior. When fixing a bug, you may want to add a test to verify the fix.

@skie
Copy link
Member Author

skie commented May 30, 2019

Work in progress yet

@markstory markstory changed the base branch from master to 4.x July 21, 2019 01:50
@markstory markstory merged commit 87deb82 into cakephp:4.x Jul 21, 2019
@markstory
Copy link
Member

Thanks for getting this started. I'm going to to continue on getting all the tests passing.

@ravage84 ravage84 changed the title Cakephp 4.x version of plugin. CakePHP 4.x Version of Plugin. Jul 24, 2019
@ravage84 ravage84 added this to the 3.x milestone Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants