Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust GA to use common workflows #572

Merged
merged 2 commits into from
Oct 9, 2022
Merged

adjust GA to use common workflows #572

merged 2 commits into from
Oct 9, 2022

Conversation

LordSimal
Copy link
Contributor

No description provided.

@LordSimal LordSimal marked this pull request as ready for review October 9, 2022 08:40
@ADmad
Copy link
Member

ADmad commented Oct 9, 2022

phpstan.neon needs to be updated to specify the paths to check.

@ADmad ADmad merged commit cc8f084 into cake5 Oct 9, 2022
@ADmad ADmad deleted the cake5-ci branch October 9, 2022 10:51
@ndm2
Copy link
Contributor

ndm2 commented Oct 9, 2022

Can common workflows be extended and have steps overridden? Because this actually needs to test all the different DBMS, and also needs additional databases and envelope variables. Ideally we could also add SQL Server.

@ADmad
Copy link
Member

ADmad commented Oct 9, 2022

Doh, I didn't notice he picked testsuite-without-db.yml instead of testsuite-db.yml which does use a db matrix. But if migrations needs special configs for various dbs too then it can continue using the custom config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants