4.x - Switch to using Phinx's feature flag defaults. #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordSimal
approved these changes
Aug 20, 2023
|
We will just have to make sure to document this so people dont trip over the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basic gist of the test changes is that the defaults adhere to Phinx's new defaults, given that this is what users will be confronted with out of the box, meaning using unsigned primary keys by default. Additional, "simpler" tests cover the rest of the feature-flag + significance permutations.
There are no changes for the null column feature flag in this PR. I'd push that separately once it's ready, so that reviewing doesn't become more complicated than it needs to be.