4.x - Remove legacy code. #625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK, one comment... if we actually wanted to test for 5.6 again instead, which wasn't done anymore ever since moving away from Travis, we could possibly do so using docker. |
|
MySQL 5.6 EOL was over 2 years ago (February 2021) |
|
I think cake5 will have a minimum of mysql 5.7 at least. |
|
Well, then let's get rid of this. Maybe I'll dare running the suite on 5.7 when I'm trying SQL Server after I'm done with all the other changes that I still have the pipeline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generating
changeColumn()calls without attributes is not possible anymore ever since #293. And MySQL 5.6... well, co comment.