Get started on PhinxAdapter #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get the rough draft of a shim adapter that will bridge between the new migrations backend and phinx's adapter interfaces. The new backend will create an instance of this adapter when running migrations and seeds. This will allow migrations to stay compatible with phinx until a future major release. I want the new backend to be opt-in initially so that we can release it, test and iterate and stabilize it when it is ready without risking broken releases. I've run into a blocker with phinx though that I need to patch first. Several DTO classes have uninitialized properties that make using their public interfaces unsafe.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the rough draft of a shim adapter that will bridge between the new migrations backend and phinx's adapter interfaces. The new backend will create an instance of this adapter when running migrations and seeds. This will allow migrations to stay compatible with phinx until a future major release. I want the new backend to be opt-in initially so that we can release it, test and iterate and stabilize it when it is ready without risking broken releases.
I've run into a blocker with phinx though that I need to patch first. Several DTO classes have uninitialized properties that make using their public interfaces unsafe.