Start implementing commands using builtin backend #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Wire up a simple status command that uses the new backend. This command needs a bunch of cleanup. But before I do any of that I want to clean up the Manager and Environment interfaces more now that I won't be able to simply inject this manager into the existing commands. Instead because of method types and property types I'm going to need to re-implement all the commands. This will let us simplify the Manager interface as it no longer needs to be swappable with Phinx's Manager class. - Deprecate ConfigurationTrait we won't need it after phinx is removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'll move this out of draft once I complete the remaining tests.
Part of #647