Update Adapter classes to use Connection pt1 #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of drilling into PDO, Migrations adapters should use the Database\Connection API instead. This creates a few behavioral differences from before. I hope that this level of abstraction wasn't commonly used by userland code.
- Update implementation to use `Connection` methods - Remove redundant tests
I really wanted to change it to assoc in 5.0 but chickened out :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove usage of
PDOwithinAdapterclasses. We can use theConnectionabstractions provided byCake\Databaseinstead. There is a potentially significant change aroundadapter->query()as it now returns Cake statement wrappers which default to numeric field fetching instead of 'assoc' fetching like phinx did.There is more that could be done around using
Connectionbetter as there is still a lot of string interpolation in query building instead of using prepared statements and lots of duplication between what phinx was doing and what cake's database layer does.Part of #647