Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Symfony/Console from Manager and Adapter #695

Merged
merged 9 commits into from
Mar 4, 2024
Merged

Conversation

markstory
Copy link
Member

@markstory markstory commented Mar 2, 2024

Continue work to remove phinx and its dependencies from migrations. These changes replace usage of Symfony/Console and use Cake's ConsoleIo objects instead.

This will likely fail CI until cakephp/cakephp#17600 is merged and released. Locally, I was getting file descriptor limits until I tracked down the leaking descriptors in StubConsoleInput.

Breaking changes

  • Adapters no longer have console input. I don't see a real world reason for this to exist that can't be replace by options being pushed into the Adapters.
  • Migrations and Seeds cannot access console input. I don't think there is a real world scenario where this would come up.

Part of #647

@markstory markstory merged commit decadf2 into no-phinx Mar 4, 2024
9 of 11 checks passed
@markstory markstory deleted the manager-console branch March 4, 2024 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant