Convert FeatureFlags to Configure operations #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markstory
force-pushed
the
fix-feature-flags
branch
from
5f7fb5d
to
65c2bee
Compare
Instead of Phinx's feature flags we should use Configure. I've chosen to read and write directly to Configure to avoid more complexity. The additional default values in `Migrator` will improve compatibility with existing usage.
markstory
force-pushed
the
fix-feature-flags
branch
from
65c2bee
to
74a4b99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of Phinx's feature flags we should use Configure. I've chosen to read and write directly to Configure to avoid more complexity.
The additional default values in
Migratorwill improve compatibility with existing usage.Part of #647