Cleanup #713
Merged
Cleanup #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internal simple task objects feels like a more maintainable pattern than traits do.
There is no suitable class in CakePHP. The database layer uses `QueryExpression` to add raw SQL to specific query clauses, and thus has no way to represent a literal value without providing a broad type.
It was not implemented before via migrations and doesn't need to exist anymore.
We only ever operate on a single path in the new flow. The console arguments drive the migration configuration much more in the built-in implementation. The parameters have good defaults and can be customized, but there is no way to have more than one path presently.
othercorey
reviewed
Apr 29, 2024
|
|
||
| if (is_string($this->values['paths']['seeds'])) { | ||
| $this->values['paths']['seeds'] = [$this->values['paths']['seeds']]; | ||
| if (is_array($this->values['paths']['seeds']) && isset($this->values['paths']['seeds'][0])) { |
There was a problem hiding this comment.
What is the point of this being an array if it's hard-coded to index 0?
There was a problem hiding this comment.
I was trying to keep compatibility with all the tests that provide a list of paths.
othercorey
reviewed
Apr 29, 2024
| @@ -71,7 +82,7 @@ protected function getTablesToBake(CollectionInterface $collection, array $optio | |||
|
|
|||
| $config = (array)ConnectionManager::getConfig($this->connection); | |||
| $key = isset($config['schema']) ? 'schema' : 'database'; | |||
| if ($config[$key] === $split[1]) { | |||
| if (isset($split[0]) && $config[$key] === $split[1]) { | |||
There was a problem hiding this comment.
Shouldn't this check $split[1] not 0?
There was a problem hiding this comment.
These were mostly to appease phpstan/psalm that were complaining about unchecked index access within the if block. I can add more isset() checks for 1 as well.
othercorey
reviewed
Apr 29, 2024
| @@ -186,7 +197,7 @@ protected function fetchTableName(string $className, ?string $pluginName = null) | |||
| $config = ConnectionManager::getConfig($this->connection); | |||
| if ($config) { | |||
| $key = isset($config['schema']) ? 'schema' : 'database'; | |||
| if ($config[$key] === $splitted[1]) { | |||
| if (isset($splitted[0]) && $config[$key] === $splitted[1]) { | |||
markstory
added a commit
that referenced
this pull request
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up several TODOs I had left behind while porting code in from phinx. I tried to leave useful commit logs for each of the changes.
Part of #647