Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote column names in the addIndex() method - Postgres #1117

Merged
merged 2 commits into from Jun 20, 2017

Conversation

fracz
Copy link
Contributor

@fracz fracz commented Jun 19, 2017

Issue similar to #1041

The addIndex method did not quote the column names, which resulted in error if one of the columns being added to the index was camel case.

Test provided.

@fracz fracz changed the title Make the addIndex() method case sensitive for Postgres Quote column names in the addIndex() method - Postgres Jun 19, 2017
@robmorgan
Copy link
Member

@fracz thanks for the test 👍

@robmorgan robmorgan merged commit 17ecab7 into cakephp:master Jun 20, 2017
@mvrhov
Copy link
Contributor

mvrhov commented Aug 7, 2017

Sorry but this one breaks the functional indexes e.g ->addIndex('tsrange(start_time,end_time)',

@mvrhov mvrhov mentioned this pull request Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants