Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing configuration item default_migration_table #1173

Merged
merged 4 commits into from
Sep 8, 2017
Merged

fixing configuration item default_migration_table #1173

merged 4 commits into from
Sep 8, 2017

Conversation

miranovy
Copy link
Contributor

@miranovy miranovy commented Sep 8, 2017

Fixing configuration item default_migration_table

@BallisticPain
Copy link

So this is why I'm no longer getting my migration versions or status to show up correctly. I was wondering. I even peeked into the source, but didn't notice this at that time.

Please MERGE & RELEASE ASAP! @lorenzo or @JayPHP

Thanks!

Copy link

@BallisticPain BallisticPain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first thing you should do in this method is call to the parent.

This method should be more like the following...

public function setOptions(array $options)
{
    parent::setOptions($options)

    if (isset($options['connection'])) {
        $this->setConnection($options['connection']);
    }

    return $this;
}

It's still important to return the PdoAdapter as that's what this class is doing in all of it's setters.

@miranovy
Copy link
Contributor Author

miranovy commented Sep 8, 2017

It is better, thanx!

@JayPHP JayPHP merged commit 69426c7 into cakephp:master Sep 8, 2017
@JayPHP
Copy link
Member

JayPHP commented Sep 8, 2017

Thanks @miranovy @BallisticPain !

@BallisticPain
Copy link

Thanks @JayPHP & @miranovy

ndm2 pushed a commit to ndm2/phinx that referenced this pull request Sep 8, 2017
lorenzo pushed a commit that referenced this pull request Sep 9, 2017
* Add tests for connection and table name configuration.

Adds tests for #1173, #1171, #1167.

* Avoid serialization error for PDO mocks.
norkus256 pushed a commit to norkus256/phinx that referenced this pull request Dec 17, 2017
* Add tests for connection and table name configuration.

Adds tests for cakephp#1173, cakephp#1171, cakephp#1167.

* Avoid serialization error for PDO mocks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants