Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify multiple primary key quoting #1214

Merged

Conversation

ntzm
Copy link
Contributor

@ntzm ntzm commented Oct 16, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 16, 2017

Codecov Report

Merging #1214 into master will decrease coverage by 0.01%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1214      +/-   ##
==========================================
- Coverage   72.18%   72.17%   -0.02%     
==========================================
  Files          35       35              
  Lines        5584     5553      -31     
==========================================
- Hits         4031     4008      -23     
+ Misses       1553     1545       -8
Impacted Files Coverage Δ
src/Phinx/Db/Adapter/SqlServerAdapter.php 0% <0%> (ø) ⬆️
src/Phinx/Db/Adapter/PostgresAdapter.php 92.69% <100%> (-0.1%) ⬇️
src/Phinx/Db/Adapter/MysqlAdapter.php 97.81% <100%> (-0.03%) ⬇️
src/Phinx/Db/Adapter/SQLiteAdapter.php 86.5% <100%> (-0.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb91426...66efca7. Read the comment docs.

@dereuromark dereuromark merged commit d84a6c7 into cakephp:master Oct 16, 2017
@ntzm ntzm deleted the simplify-multiple-primary-key-quoting branch October 16, 2017 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants