-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for configuring test db through DSN #1782
Conversation
For my local development workflow, this is going to make things a lot more annoying as now instead of just doing |
Most test harnessed don't test multiple databases at the same time. You would normally iterate on one and final test on all. However, if that is a hard requirement for phinx, we can split it up. |
I wonder if we can provide a high level entry point or composer script to test all at once locally. @MasterOdin btw: |
Yeah, that's what I meant by testing against all databases at once. My workflow is roughly:
That third step now is a much greater nuisance to do now for the sake of CI cleanliness. It's also repeating several hundred tests per run that are not database specific just making the whole thing take longer. Ideally, I think that phpunit.xml should have DB specific variables (e.g.
Yeah, I know. I use npm a bunch and hate special cases, so I'm just always using the |
e69cc48
to
d339007
Compare
Since this test suite only takes a few seconds, running a few extra tests isn't a concern. To ease the transition, the dsn is now split into separate environment variables for each db:
|
This removes the large list of environment variables needed to configure a test and replaces with a single environment variable
TEST_DSN
. This dsn is parsed into TEST_DB_CONFIG which all the tests used to configure.This also fixes
MysqlAdapter
andPostgresAdapter
when user or pass is default.Code coverage is updated to coveralls to match cakephp core and allow multiple builds to submit coverage.