Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated travis config to only run code coverage #1834

Merged
merged 1 commit into from
Jul 19, 2020
Merged

Conversation

othercorey
Copy link
Member

@othercorey othercorey commented Jul 17, 2020

With github actions setup, this reduces the configs run in travis similar to cakephp.

Adds php nightly build.

@othercorey othercorey changed the title Updated travis config to only run code coverage, prefer lowest and ph… Updated travis config to only run code coverage Jul 17, 2020
@othercorey othercorey marked this pull request as ready for review July 17, 2020 05:46
@othercorey
Copy link
Member Author

@ADmad Can you take a look?

@othercorey othercorey added this to the 0.12.x milestone Jul 17, 2020
@MasterOdin
Copy link
Member

Why not do the code coverage reporting from the GH actions?

@ADmad
Copy link
Member

ADmad commented Jul 19, 2020

@MasterOdin Because the coverage services require passing a token, which is saved in GH secrets and GH secrets are not accessible for pull requests made by users who don't have commit access to the repo.

@othercorey
Copy link
Member Author

othercorey commented Jul 19, 2020

I added postgresql 9.6 config back since we should try to test lowest supported and 9.6 is still more popular.

@dereuromark dereuromark merged commit 2fa090f into master Jul 19, 2020
@dereuromark dereuromark deleted the update-travis branch July 19, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants