Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enum #2140

Merged
merged 1 commit into from
Nov 16, 2022
Merged

Fix enum #2140

merged 1 commit into from
Nov 16, 2022

Conversation

dereuromark
Copy link
Member

Resolves #2139

@dereuromark dereuromark mentioned this pull request Nov 16, 2022
Closed
MasterOdin
MasterOdin approved these changes Nov 16, 2022
View reviewed changes
Copy link
Member

@MasterOdin MasterOdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it's worth adding some simple unit tests around this function?

@dereuromark
Copy link
Member Author

True, can definitly be a follow up
Anyone up for it?

@dereuromark dereuromark merged commit c603963 into 0.x Nov 16, 2022
@dereuromark dereuromark deleted the fix branch November 16, 2022 16:13
@AlekseiMaryasov
Copy link

@dereuromark It solved the problem, nice work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterOdin MasterOdin MasterOdin approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting a value for a column fails when we try to pass a string as values
3 participants
@dereuromark @AlekseiMaryasov @MasterOdin