fix error if plugin-paths contains unknown folder

cakephp · Sep 10, 2023 · fd89d2d · fd89d2d
1 parent d800ea4
commit fd89d2d
Show file tree

Hide file tree

Showing 2 changed files with 42 additions and 0 deletions.
diff --git a/src/Plugin.php b/src/Plugin.php
@@ -65,6 +65,9 @@ public function preAutoloadDump(Event $event): void
 
         $root = dirname(realpath($event->getComposer()->getConfig()->get('vendor-dir'))) . '/';
         foreach ($extra['plugin-paths'] as $pluginsPath) {
+            if (!is_dir($root . $pluginsPath)) {
+                continue;
+            }
             foreach (new DirectoryIterator($root . $pluginsPath) as $fileInfo) {
                 if (!$fileInfo->isDir() || $fileInfo->isDot()) {
                     continue;

diff --git a/tests/TestCase/PluginTest.php b/tests/TestCase/PluginTest.php
@@ -163,6 +163,45 @@ public function testPreAutoloadDump()
         $this->assertEquals($expected, $package->getDevAutoload());
     }
 
+    public function testPreAutoloadDumpNonExistentPluginPaths()
+    {
+        $package = new RootPackage('App', '1.0.0', '1.0.0');
+        $package->setExtra([
+            'plugin-paths' => [
+                'unknown_folder',
+            ],
+        ]);
+        $package->setAutoload([
+            'psr-4' => [
+                'Foo\\' => 'xyz/Foo/src',
+            ],
+        ]);
+        $package->setDevAutoload([
+            'psr-4' => [
+                'Foo\Test\\' => 'xyz/Foo/tests',
+            ],
+        ]);
+        $this->composer->setPackage($package);
+
+        $event = new Event('', $this->composer, $this->io);
+
+        $this->plugin->preAutoloadDump($event);
+
+        $expected = [
+            'psr-4' => [
+                'Foo\\' => 'xyz/Foo/src',
+            ],
+        ];
+        $this->assertEquals($expected, $package->getAutoload());
+
+        $expected = [
+            'psr-4' => [
+                'Foo\Test\\' => 'xyz/Foo/tests',
+            ],
+        ];
+        $this->assertEquals($expected, $package->getDevAutoload());
+    }
+
     public function testGetPrimaryNamespace()
     {
         $autoload = [