Merge pull request #42 from cakephp/deprecation-warnings

Added deprecation warning for cell and element tags
cakephp · Apr 11, 2020 · 4f2a223 · 4f2a223
2 parents 4e33d7e + aa10e66
commit 4f2a223
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/src/Twig/TokenParser/CellParser.php b/src/Twig/TokenParser/CellParser.php
@@ -38,6 +38,12 @@ class CellParser extends IncludeTokenParser
      */
     public function parse(Token $token): Node
     {
+        static $warned = false;
+        if (!$warned) {
+            $warned = true;
+            deprecationWarning('`cell` tag is deprecated. Use `cell()` function instead.');
+        }
+
         $stream = $this->parser->getStream();
 
         $variable = null;

diff --git a/src/Twig/TokenParser/ElementParser.php b/src/Twig/TokenParser/ElementParser.php
@@ -38,6 +38,12 @@ class ElementParser extends IncludeTokenParser
      */
     public function parse(Token $token): Node
     {
+        static $warned = false;
+        if (!$warned) {
+            $warned = true;
+            deprecationWarning('`element` tag is deprecated. Use `element()` function instead.');
+        }
+
         $stream = $this->parser->getStream();
         $name = $this->parser->getExpressionParser()->parseExpression();
 

diff --git a/tests/TestCase/View/TwigViewTest.php b/tests/TestCase/View/TwigViewTest.php
@@ -160,8 +160,10 @@ public function testMarkdownExtensionCustom()
      */
     public function testDeprecatedTags()
     {
-        $output = $this->view->render('deprecated_tags', false);
-        $this->assertSame("<b>10</b>\nblog_entry", $output);
+        $this->deprecated(function () {
+            $output = $this->view->render('deprecated_tags', false);
+            $this->assertSame("<b>10</b>\nblog_entry", $output);
+        });
     }
 
     /**