Merge pull request #59 from open-source-contributions/test_enhancement

Improvements about type assertions and namespaces
cakephp · Aug 21, 2020 · 5251483 · 5251483
2 parents 54ced46 + 01adacf
commit 5251483
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/tests/TestCase/Twig/Extension/AbstractExtensionTest.php b/tests/TestCase/Twig/Extension/AbstractExtensionTest.php
@@ -42,7 +42,7 @@ public function tearDown(): void
     public function testGetTokenParsers()
     {
         $tokenParsers = $this->extension->getTokenParsers();
-        $this->assertTrue(is_array($tokenParsers));
+        $this->assertIsArray($tokenParsers);
         foreach ($tokenParsers as $tokenParser) {
             $this->assertTrue($tokenParser instanceof TokenParserInterface);
         }
@@ -51,7 +51,7 @@ public function testGetTokenParsers()
     public function testGetNodeVisitors()
     {
         $nodeVisitors = $this->extension->getNodeVisitors();
-        $this->assertTrue(is_array($nodeVisitors));
+        $this->assertIsArray($nodeVisitors);
         foreach ($nodeVisitors as $nodeVisitor) {
             $this->assertInstanceOf('Twig_NodeVisitorInterface', $nodeVisitor);
         }
@@ -60,7 +60,7 @@ public function testGetNodeVisitors()
     public function testGetFilters()
     {
         $filters = $this->extension->getFilters();
-        $this->assertTrue(is_array($filters));
+        $this->assertIsArray($filters);
         foreach ($filters as $filter) {
             $this->assertInstanceOf(TwigFilter::class, $filter);
         }

diff --git a/tests/TestCase/View/TwigViewTest.php b/tests/TestCase/View/TwigViewTest.php
@@ -16,7 +16,7 @@
  * @license       https://opensource.org/licenses/mit-license.php MIT License
  */
 
-namespace Cake\TwigView\Test\TestCase;
+namespace Cake\TwigView\Test\TestCase\View;
 
 use Cake\TestSuite\TestCase;
 use TestApp\View\AppView;