Replaced configuration events with methods in TwigView #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADmad
reviewed
Mar 27, 2020
|
Any ideas why phpstan complains about the |
Static Analysis build is passing. |
|
Well yea, I adjusted the ignore list. It's just really strange that's needed. |
…on to extension class names.
othercorey
force-pushed
the
configure-events
branch
from
4090c88
to
30fd6fd
Compare
|
TwigView should now have simple tests for most things. Added render tests for simple templates and layouts with Everything seems to be loading and running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
createandinitializemethods in TwigView to replace the configuration events. Also cleans up extension and parser class names so they can be used properly.I need to write some new unit tests that are more comprehensive.