Use Twig function to call CakePHP helpers.

[ADmad]

This avoids having to preload helpers as with current usage and
also avoids having to add |raw at the end of calls to prevent escaping.

[markstory]

Love that these don't require the use of |raw. I'm not a big fan of the helper($nameMethod) as it is more typing and feels more magical. The dynamic function approach feels more consistent with how twig works in other frameworks too.

[markstory]

Should this be ViewHelperExtension?

[ADmad]

I intended to add more view related function to the extension hence the name. For e.g. a fetch function so that we can use {{ fetch('block') }} instead of {{ _view.fetch('block')|raw }}.

[othercorey]

I was thinking it might be cleaner to add functions/filters for TwigView itself directly in TwigView.

Seems odd to allow disabling TwigView-specific functions. But I won't argue if this feels correct to you.

[ADmad]

I was thinking it might be cleaner to add functions/filters for TwigView itself directly in TwigView.

That would would make the TwigView class too bloated IMO.

We aren't actually adding any new functionality to the View classes. This extension class just adds an additional layer of abstraction for accessing the View class methods/properties.

[othercorey]

ok. We can add the element and cell functions to it.

[markstory]

Some other options that may be worse or better could be:

• helper:Text:autoParagraph(...) Is visually smaller but still the same amount of letters.
• helper_text_autoParagraph(...) Using camelBack for the variables instead of PascalCase.
• h:Text:autoParagraph(...) Shorter prefix?

[ADmad]

Supporting : char would require adding additional token parsing code. Currently replacing the underscores with colons generates error Twig\Error\SyntaxError: Unexpected token "punctuation" of value ":" ("end of print statement" expected). Not really looking forward to adding more customizations if not really necessary.

helper_text_autoParagraph(...) Using camelBack for the variables instead of PascalCase.

Using text instead of Text would mean additional inflection to find matching helper property. It's better to keep the casing same and corresponding PHP code.

[ADmad]

We could go with h_Text_autoParagraph() to reduce typing.

[othercorey]

I think making the helper name and function look similar to other cake documentation/code is best so Text_autoParagraph looks similar to Text->autoParagraph().

[dereuromark]

Can you create Twig autocomplete on such functions? Then it would be similar again to normal PHP templating.
But I don't know enough about the IDE compatibility here.

[ADmad]

https://www.jetbrains.com/help/phpstorm/symfony-twig.html

I doubt any IDE would provide autocompletion for custom functions.

[dereuromark]

I see, someone would need to port https://plugins.jetbrains.com/plugin/7219-symfony-support to cakephp version then.

[othercorey]

If we aren't removing the helper context variables then should we make them globals so they can be used directly in macros?

[ADmad]

If we aren't removing the helper context variables then should we make them globals so they can be used directly in macros?

That's no necessary as helpers can already be accessed through view variable. Also the helper variable are kept just to prevent BC break, they will be eventually removed.