Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing files from app repo #33

Closed
dereuromark opened this issue Nov 3, 2014 · 5 comments · Fixed by #35
Closed

Add missing files from app repo #33

dereuromark opened this issue Nov 3, 2014 · 5 comments · Fixed by #35

Comments

@dereuromark
Copy link
Member

When upgrading existing apps, maybe the upgrade shell can put missing files and folders into the app.

E.g.:

/logs
/bin/cake

etc.

@markstory
Copy link
Member

I would also add replacing index.php and webroot/index.php. Also dropping in a default config/app.php might be nice.

@dereuromark
Copy link
Member Author

If not yet created, of course.
Sounds good.

Shall we call it "skeleton"?

@markstory
Copy link
Member

Sounds like a good name to me.

@dereuromark
Copy link
Member Author

Looking at how the code currently works, it seems it always runs subcommands on all files.
We would in this case only need the base (app root) path - and not a file itself.
Can we somehow tweak this in without having to change the whole upgrade shell?

I started here: https://github.com/cakephp/upgrade/compare/master-skeleton

This was referenced Nov 3, 2014
@markstory
Copy link
Member

Closing as #35 is open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants