Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Django 2.0; drop older Djangos that are or soon will be out of support #70

Merged
merged 4 commits into from
Mar 28, 2018

Conversation

dpoirier
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Mar 26, 2018

Coverage Status

Coverage remained the same at 86.538% when pulling 9258429 on update_versions into a85f5a6 on develop.

@@ -52,7 +52,7 @@
],
# Load models directly to pick up test-only models
# See: http://stackoverflow.com/a/25267435/347942
MIGRATION_MODULES={'treenav': 'treenav.migrations_not_run_during_tests'},
MIGRATION_MODULES={'treenav': None},

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the comment still apply?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the hack just needs updating for newer Django per the same stackoverflow discussion.

@@ -1,34 +1,39 @@
[tox]
envlist = {py27,py34,py35}-{dj1.8,dj1.9,dj1.10},py33-dj1.8,flake8,coverage,docs
envlist = {py27,py34,py36}-dj1.11,{py34,py36}-dj2.0,{py27,py36}-flake8,coverage,docs

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.4 but not 3.5?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured py34 and py36 would cover it, but we could add py35 too if you think it's necessary.

@dpoirier dpoirier merged commit 2fa1fee into develop Mar 28, 2018
@dpoirier dpoirier deleted the update_versions branch March 28, 2018 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants