Changes to support alternative configuration settings #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
| # RR: This gets a little more complicated than that. If the modem is not set up correctly, | ||
| # this field will be only the index of the number. The possible values are: | ||
| # <ModemNumber>[Index]:[Configured Phone Number]</ModemNumber> -- for multi-port and configured | ||
| # <ModemNumber>[Configured Phone Number]</ModemNumber> -- for single port and configured |
There was a problem hiding this comment.
So this part is unfortunately not quite right. Single Port Modems only put their modemnumber in there, no phone number. The only valid ModemNumber sent by our 1-port modem is: <ModemNumber>1</ModemNumber>.
Given that, I don't think there's a good way of differentiating a properly configured single-port modem from an improperly-configured multiport modem, aside from adding a setting to the configuration (yuck...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional check to parse out what comes out of the ModemNumber element.
If the modem is properly set up, the value is :;
If the modem is not properly set up, the value is then and no colon;
If the modem is a single port modem, this is either empty, or it has the SIM phone number;