fix: use variables instead of argument index, which fixes a bug

script was incorrectly using 'env' as secret name and 'secret_name' for the value/file path.
cal-itp · Feb 24, 2023 · 08fc01c · 08fc01c
1 parent 657198d
commit 08fc01c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/terraform/secrets/file.sh b/terraform/secrets/file.sh
@@ -9,4 +9,4 @@ env=$1
 secret_name=$2
 file_path=$3
 
-az keyvault secret set --vault-name "KV-CDT-PUB-CALITP-$env-001" --name $1 --file $2
+az keyvault secret set --vault-name "KV-CDT-PUB-CALITP-$env-001" --name $secret_name --file $secret_value
diff --git a/terraform/secrets/value.sh b/terraform/secrets/value.sh
@@ -9,4 +9,4 @@ env=$1
 secret_name=$2
 secret_value=$3
 
-az keyvault secret set --vault-name "KV-CDT-PUB-CALITP-$env-001" --name $1 --value "$2"
+az keyvault secret set --vault-name "KV-CDT-PUB-CALITP-$env-001" --name $secret_name --value "$secret_value"