Skip to content

Commit

Permalink
refactor(models): remove unused selection label translation fields
Browse files Browse the repository at this point in the history
they've been moved to each verifier's template
  • Loading branch information
angela-tran committed Jul 6, 2023
1 parent 444ad83 commit 2abcf0d
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 11 deletions.
4 changes: 1 addition & 3 deletions benefits/core/migrations/0001_initial.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Generated by Django 4.2 on 2023-07-06 18:45
# Generated by Django 4.2 on 2023-07-06 23:16

from django.db import migrations, models
import django.db.models.deletion
Expand Down Expand Up @@ -46,8 +46,6 @@ class Migration(migrations.Migration):
("jwe_encryption_alg", models.TextField(null=True)),
("jws_signing_alg", models.TextField(null=True)),
("selection_label_template", models.TextField()),
("selection_label", models.TextField(null=True)),
("selection_label_description", models.TextField(null=True)),
("start_title", models.TextField()),
("start_headline", models.TextField()),
("start_item_heading", models.TextField()),
Expand Down
6 changes: 0 additions & 6 deletions benefits/core/migrations/0002_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -160,8 +160,6 @@ def load_data(app, *args, **kwargs):
eligibility_type=mst_senior_type,
auth_provider=senior_auth_provider,
selection_label_template="core/includes/selection_label__login_gov.html",
selection_label=_("eligibility.pages.index.login_gov.label"),
selection_label_description=_("eligibility.pages.index.login_gov.description"),
start_title=_("eligibility.pages.start.login_gov.title"),
start_headline=_("eligibility.pages.start.login_gov.headline"),
start_item_heading=_("eligibility.pages.start.login_gov.start_item.heading"),
Expand Down Expand Up @@ -189,8 +187,6 @@ def load_data(app, *args, **kwargs):
eligibility_type=mst_veteran_type,
auth_provider=veteran_auth_provider,
selection_label_template="core/includes/selection_label__mst_veteran.html",
selection_label=_("eligibility.pages.index.veteran.label"),
selection_label_description=_("eligibility.pages.index.veteran.description"),
start_title=_("eligibility.pages.start.veteran.title"),
start_headline=_("eligibility.pages.start.veteran.headline"),
start_item_heading=_("eligibility.pages.start.veteran.start_item.heading"),
Expand All @@ -215,8 +211,6 @@ def load_data(app, *args, **kwargs):
jws_signing_alg=os.environ.get("COURTESY_CARD_VERIFIER_JWS_SIGNING_ALG", "RS256"),
auth_provider=None,
selection_label_template="core/includes/selection_label__mst_courtesy_card.html",
selection_label=_("eligibility.pages.index.mst_cc.label"),
selection_label_description=_("eligibility.pages.index.mst_cc.description"),
start_title=_("eligibility.pages.start.mst_cc.title"),
start_headline=_("eligibility.pages.start.mst_cc.headline"),
start_item_heading=_("eligibility.pages.start.mst_cc.start_item.heading"),
Expand Down
2 changes: 0 additions & 2 deletions benefits/core/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,6 @@ class EligibilityVerifier(models.Model):
jws_signing_alg = models.TextField(null=True)
auth_provider = models.ForeignKey(AuthProvider, on_delete=models.PROTECT, null=True)
selection_label_template = models.TextField()
selection_label = models.TextField(null=True)
selection_label_description = models.TextField(null=True)
start_title = models.TextField()
start_headline = models.TextField()
start_item_heading = models.TextField()
Expand Down

0 comments on commit 2abcf0d

Please sign in to comment.